Code review changes suggested by @AugustoRamos94:

- Removed unnecessary 'return' - Checking for error instead of checking value before calling error callback
agencyenterprise · Jan 23, 2023 · b3b7ba2 · b3b7ba2
1 parent d2e1bf0
commit b3b7ba2
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/RCTAppleHealthKit/RCTAppleHealthKit+Methods_Body.m b/RCTAppleHealthKit/RCTAppleHealthKit+Methods_Body.m
@@ -305,7 +305,7 @@ - (void)body_getLatestPeakFlow:(NSDictionary *)input callback:(RCTResponseSender
     [self fetchMostRecentQuantitySampleOfType:peakFlowType
                                     predicate:nil
                                    completion:^(HKQuantity *mostRecentQuantity, NSDate *startDate, NSDate *endDate, NSError *error) {
-        if (!mostRecentQuantity) {
+        if (error) {
             NSLog(@"error getting latest peak flow: %@", error);
             callback(@[RCTMakeError(@"error getting latest peak flow", error, nil)]);
         }
@@ -348,10 +348,8 @@ - (void)body_getPeakFlowSamples:(NSDictionary *)input callback:(RCTResponseSende
                           completion:^(NSArray *results, NSError *error) {
         if(results){
           callback(@[[NSNull null], results]);
-          return;
         } else {
           callback(@[RCTJSErrorFromNSError(error)]);
-          return;
         }
     }];
 }