Adds support for Brave #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
This is completely unnecessary, the icon in the toolbar is useless and the extension works without it. |
|
@jtojnar The icon indicates to the user that the extension is registered and loaded. Not entirely useless :) |
|
@jonathansampson I think checking the list of installed extensions is more than enough for that. Moreover, if all the extensions behaved like this, I would have hundred buttons in the toolbar :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled this extension into Brave (https://brave.com) tonight, and was pleased to see it working right out of the box. The only modification I had to make was to add
browser_action.default_icon.{19,38}to have the icon displayed near the address-bar.Nice extension!