-
Notifications
You must be signed in to change notification settings - Fork 517
Add Tests and Documentation for FunctionTarget #2304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
website/docs/user-guide/advanced-concepts/orchestration/group-chat/handoffs.mdx
Outdated
Show resolved
Hide resolved
* feat: add A2A Human in the loop support * chore: bump version * refactor: simplify client logic * refactor: support multiturn * lint: remove mypy ignores * tests: add Terminate human_input tests * docs: update A2A Hitl server
Update terminology across documentation to use consistent "Agent2Agent" branding instead of "Agent-to-Agent" or "agent-to-agent". Changes: - A2A documentation index page (title, heading, protocol link) - Group chat resuming documentation - Research talk abstract (Nov 2024) This provides consistent branding for the Agent2Agent (A2A) communication protocol throughout the documentation. Co-authored-by: Mark Sze <66362098+marklysze@users.noreply.github.com>
* Update sonnet model to 4.5 * fix: openai, gemini realtime * update: credentials * fix: realtime agent tool registry * fix: assistant agent test * [skip ci] docs: fix outdated docs * fix: credentials * fix: azure tests * [skip ci] docs: fix outdated docs * fix: pre-commit * fix: dev setup mdx Revert "Merge pull request #2194 from ag2ai/docs/jgr-autofix-ag_2-2188" This reverts commit 3aa474c, reversing changes made to 4d9de80. fix: user-guide --------- Co-authored-by: Mark Sze <mark@sze.family> Co-authored-by: joggrbot[bot] <107281636+joggrbot[bot]@users.noreply.github.com>
Reorganized LLM configuration methods, the 2 parts were written oppositely
) * fix client response protocol init commit * fix mypy errors * Unified Rich Response client architecture Init commit * made the role and status fields extensible in the unified response * OpenAIResponsesClient v2 init commit * OpenAIResponsesClient support for basic features * Fix groupchat which normalize content to str * [MISC] Fix mypy errors (#2167) * fix client response protocol init commit * fix mypy errors * fix: claude-code-review action for forked branches (#2171) * Update integration test * Fix new oai cient name to completions * Update notebook * Update integration test * fix client response protocol init commit * fix mypy errors * [MISC] Fix mypy errors (#2167) * fix client response protocol init commit * fix mypy errors * Add tests with real data for OpenAICompletionsClient * Add better support for GenericContent * Add support for UserRoleEnum * clean up * Update * Remove non str handling from chat completion api * refactor to use getattr * Remove message_retrieval from client v2 protocol * Add Content type enum * Add migration plan documentation * Add text property to content blocks * Add V1 client compatibility notebook * Notebook tweaks * pre-commit tidy --------- Co-authored-by: Priyanshu Yashwant Deshmukh <priyanshu@ag2.ai> Co-authored-by: Mark Sze <mark@sze.family> Co-authored-by: Mark Sze <66362098+marklysze@users.noreply.github.com>
* chromadb and sentence-transformers package versions * Agent Builder test credentials * Test tweaks
* Handoff events for AfterWorks, OnContextCondition, and LLM-based OnCondition * Remove uuid from event init parameters * Add ReplyResult transition event, move event tests out of group tool executor tests * Consolidate transition events into single file --------- Co-authored-by: Priyanshu Yashwant Deshmukh <priyanshu@ag2.ai>
…ith base64 str (#2207) * Replace Golden_Retriever image url with simple images with base64 encoding * Update tests
Co-authored-by: Qingyun Wu <qingyun0327@gmail.com> Co-authored-by: Mark Sze <66362098+marklysze@users.noreply.github.com>
* added logic to extract text from ThinkingBlock * Reorder imports in anthropic.py * added unit test for thinking block * Fix type checks to use isinstance for content * Fix trailing whitespace in test_anthropic.py --------- Co-authored-by: Yixuan Zhai <6344553+randombet@users.noreply.github.com> Co-authored-by: Priyanshu Yashwant Deshmukh <priyanshu@ag2.ai>
* Anthropic Native structured output support iniit commit * Verified fallback json is working * add strict tool use cases and fix message format * Fix groupchat tests * Add error details to request exception logging * Enforce correct SDK use case * Fix bugs on from client side * Refactor * Fix most of agentchat integration tests * Add notebook example * Support ThinkingBlock * Update notebook --------- Co-authored-by: Mark Sze <66362098+marklysze@users.noreply.github.com>
* fix: keyerror in bedrock client on format tool * fix: missing await for async call * test: integration test
* Use github static image to replace wiki image for testing * Correct test assert --------- Co-authored-by: Mark Sze <mark@sze.family>
* feat: response format support on bedrock client * feat: add test and documentaion for bedrock response format * add front matter to safeguard notebook --------- Co-authored-by: Mark Sze <66362098+marklysze@users.noreply.github.com> Co-authored-by: Mark Sze <mark@sze.family>
…2234) * OpenAI Chat Completions client structured output with streaming fix * Avoid streaming logic with OpenAI and structured outputs * Tidy * Tidy and tests * Defensive use of usage attribute * Integration tests * Test Transition fix * Test file fix
…etrieval (#2214) * Fix tool call extract logic from message_retrieval * Update reasoning support for v2 client * Use github img file to replace wiki img file for testing * Fix integration tests * Fix test from local * Test updates to o4-mini from o1-mini (deprecated) --------- Co-authored-by: Mark Sze <mark@sze.family>
* feat: Route event printing through logging * add licence headers * fix: tests * fix: move code * docs: add logging events * fix: pre-commits
* Avoid pydantic deprecation warnings on import * fix: format code to pass ruff pre-commit checks Add required blank lines before method decorators in conditional blocks and format assert statement to single line per ruff formatting rules. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: handle ImportError in test_execute_one_wolfram_query When wolframalpha package is not installed, WolframAlphaAPIWrapper raises ImportError instead of ValueError. This test now catches both exceptions to properly handle the case when the optional dependency is missing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Priyanshu Yashwant Deshmukh <priyanshu@ag2.ai> Co-authored-by: Claude <noreply@anthropic.com>
* fix(a2a): guard missing task startup * Fix mypy redundant cast in A2A client * Remove assertion for started_task in client.py Removed assertions for started_task in connection logic. * test: add coverage for agent_card=None scenario in A2A client Add two new test cases to cover the branch where agent_card is None: - test_streaming_raises_when_no_task_and_no_agent_card - test_polling_raises_when_no_task_and_no_agent_card This improves patch coverage from 40% to ~100%. * fix: remove unused cast import to pass pre-commit check The cast import was no longer needed after refactoring the code to use explicit None checks instead of type casting. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Pastukhov Nikita <diementros@yandex.ru> Co-authored-by: Priyanshu Yashwant Deshmukh <priyanshu@ag2.ai> Co-authored-by: Claude <noreply@anthropic.com>
* Documentation: fix navigation logging events * fix: misc to observability
* docs: unify DocAgent reference docs under single section * docs: unify DocAgent reference pages under a single section * docs: update Mintlify navigation and fix DocAgent links * Update mint-json-template.json.jinja * Update docagent-performance.mdx --------- Co-authored-by: Priyanshu Yashwant Deshmukh <priyanshu@ag2.ai>
* docs: unify DocAgent reference docs under single section * docs: unify DocAgent reference pages under a single section * docs: update Mintlify navigation and fix DocAgent links * Update mint-json-template.json.jinja * Update docagent-performance.mdx * Update mint-json-template.json.jinja Corrected the docagent-performance path * docs: rename DocAgent page and fix navigation path * docs: revert DocAgent file rename to restore working navigation * Update docagent-performance.mdx --------- Co-authored-by: Priyanshu Yashwant Deshmukh <priyanshu@ag2.ai>
* fix: banner image * fix: space
* Step through run * Notebook tweak * Custom events notebook * Pre-commit tidy * Fix mermaid diagrams * Correctly detect async send * Constrain type * Conversion to dedicated iterator run functions * Update documentation * Add to init and correct docs * Correct notebook docs * Remove examples from docstrings
… into fn-target/tests-and-docs
priyansh4320
requested changes
Jan 6, 2026
priyansh4320
reviewed
Jan 9, 2026
Collaborator
priyansh4320
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gabriel-eidelman , nice contribution :)
priyansh4320
approved these changes
Jan 9, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
FunctionTarget was lacking a proper test file and documentation
Checks