Prevent binary artifacts in PRs - #1239
Merged
Merged
Conversation
PR #29 (Nim SDK) accidentally committed ~15 MB of compiled binaries and .dSYM debug symbols. This adds three layers of defense: - .gitignore: block common binary extensions and build directories - CI workflow: check all PRs for binary files, build dirs, and files >500KB - lefthook pre-push: catch binary artifacts before push (opt-in)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@ag-ui/a2a-middleware
@ag-ui/a2ui-middleware
@ag-ui/mcp-apps-middleware
@ag-ui/middleware-starter
@ag-ui/a2a
@ag-ui/adk
@ag-ui/ag2
@ag-ui/agno
@ag-ui/aws-strands
@ag-ui/crewai
@ag-ui/langchain
@ag-ui/langgraph
@ag-ui/llamaindex
@ag-ui/mastra
@ag-ui/pydantic-ai
@ag-ui/server-starter
@ag-ui/server-starter-all-features
@ag-ui/vercel-ai-sdk
create-ag-ui-app
@ag-ui/client
@ag-ui/core
@ag-ui/encoder
@ag-ui/proto
commit: |
AlemTuzlak
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #29 (Nim SDK) accidentally committed ~15 MB of compiled macOS binaries and
.dSYMdebug symbols undersdks/build/tests/. This adds three layers of defense to prevent recurrence:.gitignore— block common binary extensions (.exe,.dll,.so,.dylib,.o,.obj,.a,.lib,.wasm) and build directories (**/build/,*.dSYM/)pr-check-binaries.yml) — runs on all PRs, checks for binary file extensions,build/directories,.dSYM/directories, and individual files over 500 KBTest plan
.gitignoreadditions don't affect existing tracked filespr-check-binariesworkflow runs and passes on a clean diff