AG-12655 Skip unordered category animations #2947
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMoses
reviewed
Nov 11, 2024
|
|
||
| let categoryAnimatable = true; | ||
| for (const series of this.boundSeries) { | ||
| if (!this.includeInvisibleDomains && !series.isEnabled()) continue; |
There was a problem hiding this comment.
nit: includeInvisibleDomains is always true in category axes, so this always returns false
There was a problem hiding this comment.
It's to match the original logic - in case this value ever changes
iMoses
reviewed
Nov 11, 2024
|
|
||
| if (normalizedNextIndex === -1) { | ||
| // All subsequent values must be extending (i.e. appending to) the normalized domain | ||
| normalizedIndex = Number.MAX_SAFE_INTEGER; |
There was a problem hiding this comment.
nit: use Infinity to keep consistent with similar logic in our codebase
|
Can we extract this code into |
jacobp100
commented
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-12655