Merge pull request vuelidate#126 from Krusen/required-bool-support

Support boolean values in required validator
afsarker · Apr 18, 2017 · 7aa3e04 · 7aa3e04
2 parents d767d8b + 383f1e1
commit 7aa3e04
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/validators/common.js b/src/validators/common.js
@@ -4,7 +4,7 @@ export { withParams }
 // "required" core, used in almost every validator to allow empty values
 export const req = value => {
   if (Array.isArray(value)) return !!value.length
-  if (value === undefined || value === null) {
+  if (value === undefined || value === null || value === false) {
     return false
   }
 

diff --git a/test/unit/specs/validators/required.spec.js b/test/unit/specs/validators/required.spec.js
@@ -29,6 +29,14 @@ describe('required validator', () => {
     expect(required(null)).to.be.false
   })
 
+  it('should not validate false', () => {
+    expect(required(false)).to.be.false
+  })
+
+  it('should validate true', () => {
+    expect(required(true)).to.be.true
+  })
+
   it('should validate string only with spaces', () => {
     expect(required('  ')).to.be.true
   })