Make sure the model was loaded before we attempt to remove the mesh#5499
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Mar 23, 2024
Merged
Conversation
Member
|
Thanks so much |
Elettrotecnica
added a commit
to Elettrotecnica/a-painter
that referenced
this pull request
Mar 24, 2024
Elettrotecnica
added a commit
to Elettrotecnica/a-painter
that referenced
this pull request
Mar 24, 2024
Elettrotecnica
added a commit
to Elettrotecnica/a-painter
that referenced
this pull request
Mar 24, 2024
Elettrotecnica
added a commit
to Elettrotecnica/a-painter
that referenced
this pull request
Mar 25, 2024
|
I appreciate you taking the time to fix this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4139
I stumbled on this by having a look at a-painter to see how much it would take to have it running on latest aframe. The same warning would appear and seems the two lines at https://github.com/aframevr/a-painter/blob/0deba1f3314ee4cd053bf2a2ae2854994014dd65/index.html#L50-L51 are responsible.
This seems the same situation as per the example reported in #4139 (comment).
I basically moved the check for the model being present from the remove() to the resetMesh method.
All the best