Fix bug when loading models on child entities of controllers#5415
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Dec 17, 2023
Merged
Fix bug when loading models on child entities of controllers#5415dmarcos merged 1 commit intoaframevr:masterfrom
dmarcos merged 1 commit intoaframevr:masterfrom
Conversation
Member
|
Thanks! |
Elettrotecnica
pushed a commit
to Elettrotecnica/a-painter
that referenced
this pull request
Mar 22, 2024
in particular, to get aframevr/aframe#5415
Elettrotecnica
pushed a commit
to Elettrotecnica/a-painter
that referenced
this pull request
Mar 24, 2024
in particular, to get aframevr/aframe#5415
Elettrotecnica
added a commit
to Elettrotecnica/a-painter
that referenced
this pull request
Mar 25, 2024
in particular, to get aframevr/aframe#5415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The various controls components handle the
model-loadedevent to configure the controller models. However, they don't check where themodel-loadedevent originates from. In case a child entity loads a model, the controls components would incorrectly assume it's the controller model that just loaded in.This actually causes issues in A-Painter where the
model-loadedevent of the brush-tip would trigger theonModelLoadedfor theoculus-touch-controls(and others).Changes proposed:
onModelLoadedchecking that the event didn't originate from any child element