Bug on exitVR (quest 2)

[Roxcsas]

On quest 2 browser after i click the VR button to enter in VR mode and than exit, the scene is empty with nothing else just the VR button.
If i click the VR button again to enter in VR mode i can still see everything.
This wasn't happening in A-Frame 1.5.0, i didn't check A-Frame 1.6.0

• A-Frame Version: 1.7.0

• Platform / Device: Quest 2 default browser

[dmarcos]

Do you have a link to reproduce?

[dmarcos]

I can reproduce in the examples. That's a regression when we bumped to THREE r173

First bad commit: 784aa2f238b7
Last good commit: 72cc193cfcd

I had tested this on emulator. I should have tested on device.

No console errors.

[mrxz]

The regression isn't in Three.js, but in the supermedium/three.js fork. The logic added in supermedium/three.js#20 ensures that renderer.setRenderTarget(null) defaults to the WebXR swapchain texture. However, when the WebXRManager tries to switch back to the render target from before the immersive session, it passes null which at that point still gets translated to the WebXR swapchain texture.

It should be easy to fix by swapping some lines around in WebXRManager. Before setting the render target, the isPresenting flag should be set to false: https://github.com/supermedium/three.js/blob/dev/src/renderers/webxr/WebXRManager.js#L182-L194

[dmarcos]

@Roxcsas Can you give this one a try: https://sepia-strengthened-dust.glitch.me/ ? Is the issue gone? Thanks

[Roxcsas]

@Roxcsas Can you give this one a try: https://sepia-strengthened-dust.glitch.me/ ? Is the issue gone? Thanks

Yes this works

[dmarcos]

Thanks! This is fixed now on master. I set isPresent = false before calling setRenderTarget as @mrxz suggested