-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove renderer physicallyCorrectLights property and update default lighting setup (r165) #5546
Comments
For context: https://discourse.threejs.org/t/updates-to-lighting-in-three-js-r155/53733#migrating-2:
Also, since things won't be the exact same as before, let's also update the default
|
Anyone wants to open a PR? |
Each point I mentioned can be a separate PR, but the two first points are probably good to do together. That may be a good first time contribution if anyone wants to contribute. @mrxz maybe you know, is there maybe some formula we can apply to find the equivalent light color to have more or less the same rendering? |
The colour itself does not need to be changed, only the intensity by a factor of PI. Since the decay/falloff is different the results won't be identical, but there isn't really anything that can be done about that. Though I expect that the difference won't really be noticeable. |
Looking to cut A-Frame 1.7.0 and we need this fixed. Anyone want to volunteer PRs? |
…WebGLRenderer.useLegacyLights deprecation (fix aframevr#5556, aframevr#5546)
Description:
WebGLRenderer.useLegacyLights
was removed in three r165, default scene now looks much darker.We really should've defaulted to useLegacyLights=false (physicallyCorrectLights true in aframe renderer) when we switched the default for colorManagement to true in aframe 1.5.0, but that's done we can't go back in the past.
We should:
The text was updated successfully, but these errors were encountered: