Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Endpoint Option for Local Development #18

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Conversation

afgallo
Copy link
Owner

@afgallo afgallo commented Jun 2, 2024

This PR introduces a new feature that allows developers to specify a custom endpoint for the SNS client. This is particularly useful for local development and testing, where developers might want to use a local mock SNS service instead of the real AWS service.

Changes:

  • Added an endpoint option to the SNSAdapter constructor. This option is used when creating the SNSClient.
  • Updated the SNSAdapter class to use the endpoint option if it is provided.
  • Added a new test case to verify that the SNSAdapter correctly uses the endpoint option when it is provided.

Testing:

All existing tests pass, and a new test was added to check the new functionality. The new test creates a SNSAdapter with a custom endpoint and verifies that the SNSClient uses the correct endpoint.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3e78777) to head (3ba8b49).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           47        58   +11     
=========================================
+ Hits            47        58   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afgallo afgallo merged commit fd7ac82 into main Jun 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants