This repository has been archived by the owner on Oct 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
su8ru
previously approved these changes
Oct 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
テストの穴はありそうだけど
ibuki2003
suggested changes
Oct 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testはもういいや…別issueでなおしたいね(永遠に治らないやつ…)
} | ||
$q = $this->validate($request, [ | ||
'name' => ['string'], | ||
'type' => ['string', 'regex:/^(normal|frontier|stage)$/'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- stringは暗黙指定されてる
- https://readouble.com/laravel/6.x/ja/validation.html#rule-in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あの
🛫 → 💥 |
su8ru
previously approved these changes
Oct 16, 2020
Takeno-hito
force-pushed
the
feature/#98_afes_online
branch
from
October 16, 2020 04:04
f9dd96e
to
8fa8a39
Compare
🛫 2️⃣ |
🛫 3️⃣ |
su8ru
approved these changes
Oct 16, 2020
ibuki2003
approved these changes
Oct 16, 2020
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve: #98
何がお困りかというとテストがうまく使いこなせない、そこをどう解決するか決まったらもうprに成り代わります