Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making each_row&each_instance methods more concise #7

Merged
merged 2 commits into from
May 13, 2014

Conversation

RaVbaker
Copy link
Contributor

@RaVbaker RaVbaker commented May 9, 2014

Now it's going to use the block variable from method and it's using options argument for each_row call.

It fixes #6

@afair
Copy link
Owner

afair commented May 13, 2014

Thanks for catching the buffer_size/block_size confusion.

Actually, the option should be called :batch_size for uniformity with find_in_batches(), but I don't want to create a migration issue with this. I think I will try to make them (eventually) consistent. :-)

afair added a commit that referenced this pull request May 13, 2014
Making each_row&each_instance methods more concise
@afair afair merged commit 2216bac into afair:master May 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AR#each_row doesn't accept options
2 participants