Do not load association during initialization of cursor. #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I have spotted when cursor is used on association the association is actually loaded (sql query is triggered).
I have found out it is related to type check in
iterate_type
. Using==
to compare type triggers the association query. I have added type check ofŧype.class
to avoid calling equality operator on active record relation.There's need to access
@type
viainstance_variable_get
on cursor in specs, but I think it is not worth it to exposetype
to public just because of specs.before (cursor is initialized and prices relation is loaded)
after (cursor is initialized and prices relation is not loaded)