Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cursors are closed #5

Merged
merged 1 commit into from
May 13, 2014
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/postgresql_cursor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,9 @@ def each(&block)
break if has_do_while && rc != @options[:while]
end
rescue Exception => e
close
raise e
ensure
close
end
end
@count
Expand All @@ -89,7 +90,7 @@ def fetch
end

# Private: Fetches the next block of rows into @block
def fetch_block(block_size=nil)
def fetch_block(block_size=nil)
block_size ||= @block_size ||= @options.fetch(:block_size) { 1000 }
@result = @connection.execute("fetch #{block_size} from cursor_#{@cursor}")
@block = @result.collect {|row| row } # Make our own
Expand Down