Avoid referencing the AR connection adapter in the toplevel #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #41 not by documenting but by fixing the code.
This implementation expects AR postgresql connection adapter to be already loaded while loading this gem, but this assumption is not always true because AR usually loads the adapters after loading
config/database.ymland datermining the database adapter to load.Also, defining a global constant like this
OIDthing inside a gem is pretty rude. It may conflict with the users' application code or other gems.This new constant has been introduced via #35 just for resolving an ambiguous
OIDconstant refernce, but that ambiguity here could be more simply and naturally solved just by referencing the constant with the absolute path per each AR version.