-
Notifications
You must be signed in to change notification settings - Fork 28
depr: deprecate GazeDataFrame
in favor of Gaze
#1119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1119 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 93 95 +2
Lines 4042 4095 +53
Branches 715 719 +4
=========================================
+ Hits 4042 4095 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
please fix merge conflicts -- will check asap afterwards |
Pull request was converted to draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'pytest-benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50
.
Benchmark suite | Current: d499b1c | Previous: a5a4a03 | Ratio |
---|---|---|---|
tests/benchmark/import_test.py::test_import_pymovements_subprocess |
0.027569107509362815 iter/sec (stddev: 4.020480411210118 ) |
0.5416393706851328 iter/sec (stddev: 0.6272416332904706 ) |
19.65 |
This comment was automatically generated by workflow using github-action-benchmark.
DeprecationWarning:
GazeDataFrame
has been renamed toGaze
in v0.22.0 and will be removed in v0.27.0.Description
Renames
GazeDataFrame
to the shorterGaze
. ImplementsGazeDataFrame
as deprecated alias.The following warnings are printed on instantiation and subclassing:
Implemented changes
GazeDataFrame
toGaze
GazeDataFrame
as deprecated class aliasHow Has This Been Tested?
Context
related issues:
GazeDataFrame
toGaze
andEventDataFrame
toEvents
#921Checklist: