Skip to content

dataset: ETDD70 #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dataset: ETDD70 #1105

wants to merge 2 commits into from

Conversation

SiQube
Copy link
Member

@SiQube SiQube commented Apr 19, 2025

No description provided.

Copy link

codecov bot commented Apr 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (37f0bcd) to head (be60cec).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1105   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           91        92    +1     
  Lines         4028      4049   +21     
  Branches       712       712           
=========================================
+ Hits          4028      4049   +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SiQube SiQube enabled auto-merge (squash) April 19, 2025 10:04
@SiQube SiQube force-pushed the siqube-dataset-edd branch from 3e03d3c to dadb62c Compare April 19, 2025 10:50

resources:
gaze:
- resource: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get how that should work without specifying an URL? have you tested this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, probably because mirror is already the full path?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean the dataset is downloaded twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'll change to mirror only. its the same issue as in the other PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SiQube SiQube requested a review from dkrako May 20, 2025 17:10
@SiQube SiQube force-pushed the siqube-dataset-edd branch from 597a6dd to be60cec Compare May 20, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants