-
Notifications
You must be signed in to change notification settings - Fork 28
dataset: ETDD70 #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
dataset: ETDD70 #1105
Conversation
21bafcd
to
3e03d3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 91 92 +1
Lines 4028 4049 +21
Branches 712 712
=========================================
+ Hits 4028 4049 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3e03d3c
to
dadb62c
Compare
src/pymovements/datasets/etdd70.yaml
Outdated
|
||
resources: | ||
gaze: | ||
- resource: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get how that should work without specifying an URL? have you tested this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, probably because mirror is already the full path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean the dataset is downloaded twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I'll change to mirror only. its the same issue as in the other PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
597a6dd
to
be60cec
Compare
No description provided.