[Ceres]: Document FATE delegation signatures#520
Merged
Conversation
hanssv
force-pushed
the
delegation_signatures
branch
from
b3c70d7 to
43e9ab6
Compare
This was referenced Nov 23, 2023
davidyuk
approved these changes
Dec 6, 2023
Member
davidyuk
left a comment
davidyuk
left a comment
There was a problem hiding this comment.
Related issues aeternity/aeternity#4177 aeternity/aeternity#4178
|
|
||
| There are five different delegation signatures: | ||
| - `AENS_PRECLAIM` - the user signs: `owner account + contract` | ||
| - `AENS_CLAIM`,`AENS_UPDATE`, `AENS_TRANSFER`, `AENS_REVOKE` - the user signs: |
Member
There was a problem hiding this comment.
Suggested change
| - `AENS_CLAIM`,`AENS_UPDATE`, `AENS_TRANSFER`, `AENS_REVOKE` - the user signs: | |
| - `AENS_CLAIM`, `AENS_UPDATE`, `AENS_TRANSFER`, `AENS_REVOKE` - the user signs: |
davidyuk
reviewed
Dec 6, 2023
| We use the tag `0x1a01` to identify delegation signatures. We use the following | ||
| tags/types to identify the different delegation signatures: | ||
|
|
||
| | Tag | Delegation type | |
Member
There was a problem hiding this comment.
With this tag, we don't need prefixed ids and can use binary as before, but I don't have a preference.
Member
Author
There was a problem hiding this comment.
Let's do it like this, it is in line with the other serializations...
ThomasArts
approved these changes
Dec 11, 2023
radrow
approved these changes
Jan 9, 2024
| - `ORACLE_RESPOND` - the user signs: `query id + contract` | ||
|
|
||
| To protect about cross network re-use of signatures, the data to be signed is | ||
| also prefixed with the _network id_. |
Member
There was a problem hiding this comment.
Why not mention the net id everywhere? When I see "the user signs" I would expect that the user signs exactly that with no qualifications in a paragraph after.
This is what I hate in law language the most.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Ceres we introduce better, more structured, delegation signatures. This (a) properly documents the old delegation signature, and (b) documents the new more structured signatures.
This PR is supported by the Æternity Foundation