Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

fix: run tests also with python 3.8 #354

Merged
merged 8 commits into from
Jan 29, 2020
Merged

fix: run tests also with python 3.8 #354

merged 8 commits into from
Jan 29, 2020

Conversation

noandrea
Copy link
Contributor

@noandrea noandrea commented Jan 29, 2020 •
edited
Loading

closes #275

@noandrea noandrea added this to the 6.3.0 milestone Jan 29, 2020
@noandrea
add script override for travis
ed9e9ce 
update version requirements docs
@codecov
Copy link

codecov bot commented Jan 29, 2020 •
edited
Loading

Codecov Report

Merging #354 into develop will increase coverage by 0.36%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #354      +/-   ##
=========================================
+ Coverage    77.63%    78%   +0.36%     
=========================================
  Files           17     17              
  Lines         2759   2778      +19     
=========================================
+ Hits          2142   2167      +25     
+ Misses         617    611       -6
Impacted Files Coverage Δ
aeternity/transactions.py 89.9% <96.66%> (+2.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed9e9ce...e6430d7. Read the comment docs.

@shekhar-shubhendu
Copy link
Contributor

With the current approach 5 different jobs are getting generated:

  • Python 3.7
    • 1 combine test job
    • 3 parallel test jobs
  • Python 3.8
    • 1 combine test job

I think if required we can remove the 3 parallel test jobs for now and parallelize the 2 jobs i.e. 1 each for python 3.7 and 3,8, until we find a better solution.

shekhar-shubhendu
shekhar-shubhendu suggested changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@shekhar-shubhendu shekhar-shubhendu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments in the pr

@noandrea
Copy link
Contributor Author

I believe the better strategy is to removed the parallel tests

@noandrea
Merge branch 'develop' into fix/gh275_py38
c68253a
@noandrea
remove parallel tests
bdff1cf 
parallel tests make the test suite run faster
but they add another layer of complexity
when onboarding new maintainers
@noandrea
Merge branch 'fix/gh275_py38' of github.com:aeternity/aepp-sdk-python…
1915b53 
… into fix/gh275_py38
@noandrea
set the required python versoin to 3.7
a7dba4e
@noandrea
cleanup dev env and commands
be3d880 
- remove depenency to dephell, use poetry for export of requirements
- use poetry for publish of packages and for build
- update required poetry version to 1.0.1
@noandrea
include deve dependencies in deps export
e6430d7
@noandrea noandrea merged commit 1f21bcb into develop Jan 29, 2020
@noandrea noandrea deleted the fix/gh275_py38 branch January 29, 2020 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shekhar-shubhendu shekhar-shubhendu shekhar-shubhendu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Error building with python 3.8 (cpython build error)
2 participants
@noandrea @shekhar-shubhendu