Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

feat(compiler): validate on-chain bytecode #333

Merged
merged 7 commits into from
Dec 10, 2019
Merged

feat(compiler): validate on-chain bytecode #333

merged 7 commits into from
Dec 10, 2019

Conversation

shekhar-shubhendu
Copy link
Contributor

No description provided.

@shekhar-shubhendu shekhar-shubhendu self-assigned this Dec 6, 2019
@noandrea noandrea modified the milestones: 6.2.0, 6.3.0 Dec 6, 2019
noandrea
noandrea suggested changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@noandrea noandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a section in the how to documentation about how to validate a source code,
you can include the content of the test_sophia_validate_bytecode as reference

noandrea
noandrea reviewed Dec 6, 2019
View reviewed changes
tests/test_compiler.py Outdated Show resolved Hide resolved
@shekhar-shubhendu
Copy link
Contributor Author

closes #329

noandrea
noandrea approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@noandrea noandrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@shekhar-shubhendu shekhar-shubhendu merged commit 1cb0d1a into develop Dec 10, 2019
@shekhar-shubhendu shekhar-shubhendu deleted the feature/compiler-validate-bc branch December 10, 2019 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nduchak nduchak nduchak approved these changes

@noandrea noandrea noandrea approved these changes

Assignees

@shekhar-shubhendu shekhar-shubhendu

Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhar-shubhendu @noandrea @nduchak