Skip to content

chore(AEX-2): Check for networkId on every signTransaction message#996

Merged
nduchak merged 5 commits intodevelopfrom
feat/aex-2-network-check
May 25, 2020
Merged

chore(AEX-2): Check for networkId on every signTransaction message#996
nduchak merged 5 commits intodevelopfrom
feat/aex-2-network-check

Conversation

@nduchak
Copy link
Contributor

@nduchak nduchak commented May 22, 2020

Update networkId of Wallet client for each request

Update networkId of Wallet client for each request
@nduchak
Copy link
Contributor Author

nduchak commented May 22, 2020

Closes: #998

…o example wallet app. Add node auto-switching for AEPP example
Copy link
Collaborator

@thepiwo thepiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me! thanks

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #996 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #996   +/-   ##
========================================
  Coverage    92.63%   92.63%           
========================================
  Files           58       58           
  Lines         3096     3097    +1     
========================================
+ Hits          2868     2869    +1     
  Misses         228      228           
Impacted Files Coverage Δ
es/utils/aepp-wallet-communication/rpc/aepp-rpc.js 100.00% <ø> (ø)
es/utils/aepp-wallet-communication/helpers.js 95.45% <100.00%> (ø)
.../utils/aepp-wallet-communication/rpc/wallet-rpc.js 98.98% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d8e82...d0fe171. Read the comment docs.

@nduchak nduchak merged commit 23de7ed into develop May 25, 2020
@nduchak nduchak deleted the feat/aex-2-network-check branch May 25, 2020 13:08
@nduchak nduchak mentioned this pull request May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants