rpc client: Handle case if aepp opened without wallet#388
Merged
Conversation
davidyuk
force-pushed
the
feature/rpc-better-exception
branch
from
83d9a99 to
4ed6f5e
Compare
nduchak
approved these changes
May 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
window.parentis equal towindowif a web page opened as usual. If we accidentally start dapp in this way (also not settingparentoption), thenrpc/clientwill send ahelloto itself and fail with exception:I think much cleaner for dapp developers to handle this case separately. In that case this PR makes dapp to throw: