Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return unpackTx's type in sendTransaction #1762

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Return unpackTx's type in sendTransaction #1762

wants to merge 10 commits into from

Commits on Feb 22, 2023

  1. refactor(chain)!: don't return confirmationHeight in sendTransaction 

    BREAKING CHANGE: `confirmationHeight` is not returned in `sendTransaction`
Use `getHeight` to get current height.
    @davidyuk
    davidyuk committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    80eb807 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. refactor(tx-builder)!: drop denomination option 

    BREAKING CHANGE: tx builder doesn't support `denomination` option
Convert AE amounts to aettos manually or use `formatAmount` helper function.
    @davidyuk
    davidyuk committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    162ad17 View commit details
    Browse the repository at this point in the history

  2. refactor(chain)!: don't accept format in getBalance and return bigint 

    BREAKING CHANGE: `getBalance` return bigint and not accepting `format`
Use `formatAmount` to format manually. Call `.toString()` on return value if necessary.
    @davidyuk
    davidyuk committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    ed30cbc View commit details
    Browse the repository at this point in the history

  3. refactor(channel)!: balances returns bigints instead of strings 

    BREAKING CHANGE: Channel:balances returns bigints instead of strings
Call `.toString()` on return returned balance if necessary.
    @davidyuk
    davidyuk committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    2be7607 View commit details
    Browse the repository at this point in the history

  4. refactor(chain)!: don't accept string in transferFunds 

    BREAKING CHANGE: `transferFunds` not accepts string anymore
Implement a custom algorithm if you need accuracy more than provided by number type.
    @davidyuk
    davidyuk committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    f27b0d6 View commit details
    Browse the repository at this point in the history

  5. refactor(tx-builder)!: accept nonce only as number 

    BREAKING CHANGE: `buildContractId`, `oracleQueryId` accepting nonce only as a number
    @davidyuk
    davidyuk committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    f0bb3eb View commit details
    Browse the repository at this point in the history

  6. refactor(chain): use Int for types representing coin amounts

    @davidyuk
    davidyuk committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    d25d790 View commit details
    Browse the repository at this point in the history

  7. fixup remove denomination

    @davidyuk
    davidyuk committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    57cebbe View commit details
    Browse the repository at this point in the history

  8. fix(tx-builder): don't ignore increment option

    @davidyuk
    davidyuk committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    cd96326 View commit details
    Browse the repository at this point in the history

  9. refactor(tx-builder)!: convert coint amounts to bigints [wip]

    @davidyuk
    davidyuk committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    1874ea9 View commit details
    Browse the repository at this point in the history