feat: add top miners endpoint #2000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaboiishere
force-pushed
the
top-miners
branch
from
4f5d992 to
e74bc48
Compare
yaboiishere
force-pushed
the
top-miners
branch
from
d572056 to
b436a69
Compare
sborrazas
approved these changes
Feb 5, 2025
| @type top_miner_index() :: | ||
| {Stats.interval_by(), Stats.interval_start(), pubkey()} | ||
| @type top_miner() :: | ||
| record(:top_miner, index: top_miner_index, count: pos_integer()) |
There was a problem hiding this comment.
We already have the Model.miner() record, why not use that to store the amount of times it has been a miner?
|
|
||
| key_boundary = | ||
| {{interval_by, min_date, 0, Util.min_bin()}, | ||
| {interval_by, max_date, Util.max_int(), Util.max_256bit_bin()}} |
There was a problem hiding this comment.
I'm not sure I'm following the use of this implementation? what's the benefit of getting the top miners per month? wouldn't you want the global top miners?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1963