Skip to content

Handle strategies with no parameters #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brianbaquiran wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle strategies with no parameters #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1517ea7
Test for strategy without parameters, such as default strategy
Sep 12, 2018
ae91043
Handle strategy without parameter, such as default strategy
Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/test_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ def test_unknown_strategy(self):
assert not result[0](basically_anything_here='foo')
assert log.warning.called

def test_no_parameter(self):
strategies = {'Foo': mock.Mock(return_value='R')}
feature = {'strategies': [
{'name': 'Foo'},
]}

result = features.feature_gates(strategies, feature)
assert len(result) == 1
assert result == ['R']


class TestFeature(TestCase):
def test_happy_path(self):
Expand Down
2 changes: 1 addition & 1 deletion unleash_client/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
def feature_gates(strategies, feature):
tests = []
for args in feature['strategies']:
name, parameters = args['name'], args['parameters']
name, parameters = args['name'], args.get('parameters', {})
strategy = strategies.get(name)
if strategy:
test = strategy(**parameters)
Expand Down