Undo deleting tarball after extracting since it re-downloads every time#188
Merged
Undo deleting tarball after extracting since it re-downloads every time#188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged this too hastily in #180. The deleting works, but Pooch (understandably) doesn't recognise the extracted data as it being present, only the original tarball. That makes sense, since it can't calculate a hash from the extracted folder to check whether it's been updated and needs to be re-downloaded either.
Theoretically we could devise a system that stores the hash of the tarball to a txt file and then deletes the tarball, so that we can use the stored hash as reference. That's not supported in current Pooch however, and don't feel like implementing all of that manually atm.