Merged
Conversation
…rb region_predictions)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the barplot logic (for what I think is the third time), but now I think I'm finally happy with it.
This integrates
regionandregion_predictionsinto one function. There's just one function now, provisionally calledscores(but to be renamed in #183), which can take one or multiple targets. I'd already considered making 'region' support multiple model_names like other functions anyway, and when renaming I couldn't find a good name that distinguishedregion_predictionsfromregion, a sign that the functions overlapped too much.By default (
targets=None), it plots ground truth + all predictions akin toregion_predictions, butscores(targets='truth'/'model_name')to gets you back to plotting a specific one. You can of course also plot only the prediction layers (scores(targets=adata.layers.keys())), plot a subset of the targets, plot them in a different order, etc etc.region,region_predictionsandpredictionstubs are left as wrappers to match the old behavior, with deprecation notices pointing people toscores(or the new name once it's renamed).