Skip to content

Script rework - #2012

Draft
wolfcomp wants to merge 91 commits into
mainfrom
script_rework
Draft

wolfcomp wants to merge 91 commits into
mainfrom
script_rework

Conversation

@wolfcomp

Copy link
Copy Markdown
Collaborator

Currently only contains rework for the IDA scripts.

Ghidra scripts will need updating before this will be marked as ready.

Scripts are slated to be changed over to the new files and methods with 8.0 if everything gets updated in time.

@github-actions github-actions Bot added the breaking change PR contains breaking changes and wont be merged before a new patch label Oct 13, 2026
@wolfcomp
wolfcomp force-pushed the script_rework branch 2 times, most recently from b61b548 to 45b8fec Compare October 15, 2026 20:54
no longer maintained by the person that created them
- Also converts structs_schema.py to dataclass types
prep work for new importer script
for less duplication code between IDA and Ghidra
this will only exists while working on the new scripts
just so people don't accidentally commit runtime/testing files
IDA converts the first naming of _ to . for functions while ghidra doesn't
@github-actions

Copy link
Copy Markdown
Contributor
Details

Breaking Changes

Type exists in left but not in right

FFXIVClientStructs.FFXIV.Client.Game.UI: 1

ContentsFinder: 1

  • LootRule

FFXIVClientStructs.FFXIV.Common.Component.Excel.ExcelSheet: 1

WaiterContainer: 1

  • WaiterEntry

Member exists in left but not in right

FFXIVClientStructs.FFXIV.Client.Game.UI: 2

ContentsFinder: 1

  • FFXIVClientStructs.FFXIV.Client.Game.UI.ContentsFinder.LootRule LootRules

ContentsFinderQueueInfo: 2

  • FFXIVClientStructs.FFXIV.Client.Game.UI.ContentsFinder.LootRule PoppedContentLootRule
  • void OnQueuePop(FFXIVClientStructs.FFXIV.Client.Enums.ContentsFinderQueueState, uint, System.IntPtr, bool, FFXIVClientStructs.FFXIV.Client.Game.UI.ContentsFinder.LootRule, ulong, System.IntPtr, bool, bool, bool, bool, bool, bool)

FFXIVClientStructs.FFXIV.Client.Game.UI.ContentsFinderQueueInfo.Delegates: 1

OnQueuePop: 2

  • void Invoke(FFXIVClientStructs.FFXIV.Client.Game.UI.ContentsFinderQueueInfo*, FFXIVClientStructs.FFXIV.Client.Enums.ContentsFinderQueueState, uint, System.IntPtr, bool, FFXIVClientStructs.FFXIV.Client.Game.UI.ContentsFinder.LootRule, ulong, System.IntPtr, bool, bool, bool, bool, bool, bool)
  • System.IAsyncResult BeginInvoke(FFXIVClientStructs.FFXIV.Client.Game.UI.ContentsFinderQueueInfo*, FFXIVClientStructs.FFXIV.Client.Enums.ContentsFinderQueueState, uint, System.IntPtr, bool, FFXIVClientStructs.FFXIV.Client.Game.UI.ContentsFinder.LootRule, ulong, System.IntPtr, bool, bool, bool, bool, bool, bool, System.AsyncCallback, object)

FFXIVClientStructs.FFXIV.Common.Component.Excel.ExcelSheet: 1

WaiterContainer: 1

  • FFXIVClientStructs.FFXIV.Common.Component.Excel.LinkList<FFXIVClientStructs.FFXIV.Common.Component.Excel.ExcelSheet.WaiterContainer.WaiterEntry> Base

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change PR contains breaking changes and wont be merged before a new patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant