Support ttl changes through write policy#136
Merged
tim-aero merged 8 commits intoaerospike:mainfrom Jan 24, 2023
Merged
Conversation
- Added a unit test for LocalDateMapper and LocalDateTimeMapper - Changed LocalDateMapper to use EpochDays - Changed LocalDateTimeMapper to preserve full precision of the LocalDateTime down the nanosecond level.
Added a mapper for LocalTime to round out Java 8 date / time classes. Included a unit test for them.
Made 2 changes to the TTL behaviour: 1. If a WritePolicy is explicitly passed to the save method, the settings in this policy are honoured, so neither the TTL nor the SendKey will be altered. 2. Defaulted the AerospikeRecord.ttl() to Integer.MIN_VALUE and changed the logic so this effectively becomes "not set". Without this change a TTL set via an initial policy passed to the Builder (and not via the AerospikeRecord annotation) would not be honoured under any circumstances.
reugn
approved these changes
Jan 24, 2023
|
Thanks! When can we expect a release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #132
3 main changes: