Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMWK-604 Implement XDR restore handler #197

Merged
merged 12 commits into from
Jan 9, 2025

Conversation

filkeith
Copy link
Contributor

@filkeith filkeith commented Jan 7, 2025

No description provided.

@filkeith filkeith changed the base branch from main to xdr-support January 7, 2025 14:13
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 71.01449% with 200 lines in your changes missing coverage. Please review.

Project coverage is 78.86%. Comparing base (9f4230e) to head (bb9f3ff).

Files with missing lines Patch % Lines
cmd/internal/app/asrestore.go 24.09% 59 Missing and 4 partials ⚠️
cmd/internal/app/asbackup.go 47.22% 17 Missing and 2 partials ⚠️
io/aerospike/payload_writer.go 42.42% 19 Missing ⚠️
porcessor_file_reader.go 70.31% 13 Missing and 6 partials ⚠️
cmd/internal/app/readers.go 77.41% 8 Missing and 6 partials ⚠️
cmd/internal/app/validation.go 26.31% 10 Missing and 4 partials ⚠️
handler_restore.go 91.02% 5 Missing and 2 partials ⚠️
client.go 64.70% 4 Missing and 2 partials ⚠️
io/aws/s3/reader.go 33.33% 3 Missing and 1 partial ⚠️
cmd/internal/app/configs.go 91.17% 2 Missing and 1 partial ⚠️
... and 13 more
Additional details and impacted files
@@               Coverage Diff               @@
##           xdr-support     #197      +/-   ##
===============================================
- Coverage        79.90%   78.86%   -1.04%     
===============================================
  Files              105      108       +3     
  Lines             9060     9316     +256     
===============================================
+ Hits              7239     7347     +108     
- Misses            1357     1486     +129     
- Partials           464      483      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- fix state file test
- reader test fix
- reworked restore
- fix reader and encoder initialization.
@filkeith filkeith marked this pull request as ready for review January 9, 2025 08:13
client.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
cmd/asrestore/cmd/root.go Outdated Show resolved Hide resolved
cmd/internal/app/asbackup.go Show resolved Hide resolved
cmd/internal/app/asrestore.go Outdated Show resolved Hide resolved
cmd/internal/flags/restore.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
internal/processors/change_namespace.go Outdated Show resolved Hide resolved
- log for stop xdr action
@filkeith filkeith merged commit 793473d into xdr-support Jan 9, 2025
4 checks passed
@filkeith filkeith deleted the FMWK-604-xdr-restore-handler branch January 9, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants