Operator Overloading for Constant Class #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @8hantanu, Codacy is not allowed to analyse my PR because it is on Simplify Branch. (not dev branch)* |
Member
|
@Alii-Khaled Not a problem. As long as the code is complying with Travis CI tests, it's good, Anyway, I will add the simplify branch to codacy soon. |
8hantanu
reviewed
Apr 21, 2019
8hantanu
reviewed
Apr 21, 2019
Making Constant initialization much easier & changed Tests according to that change.
Contributor
Author
|
@8hantanu Done. 👍 |
8hantanu
requested changes
Apr 25, 2019
Member
8hantanu
left a comment
8hantanu
left a comment
There was a problem hiding this comment.
Can you add the test cases for the following in test_functions.py?
- Constant + Expression
- Constant - Expression
- Expression - Constant
- Constant * Expression
- Constant / Expression
- Expression / Constant
- Constant ** Constant
8hantanu
reviewed
Apr 29, 2019
Co-Authored-By: Alii-Khaled <47671499+Alii-Khaled@users.noreply.github.com>
8hantanu
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have Added the following:
Addition, Subtraction, Multiplication, division & Power Operator Overloading functions for Constant Class.
Many Test cases for all these Functions.
isZero() function in Function Class that returns whether that Function ( constant or anything else ) is Zero or not, in order to make calculations according to its output. ( for example multiplication by zero )
I have Modified Constant Exponential Class to work well with Constant exponents as ( 5^(x+3) ).
-For Code Coverage : I found out that during Implementation of Operator overloading function Code coverage could decrease a little bit - Although here I increased Code coverage by 0.7% - , but once we finish All Classes we will rapidly increase code coverage as we will remove the existing Add/Sub & Mul/Div .
I hope @8hantanu , @sidkothiyal Review the Code to improve it and to let us work on other Classes in a better way.