Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard: fix a bug about 'copy from selenoid and paste to selenoid' #497

Merged
merged 7 commits into from
Oct 13, 2022
Merged

Clipboard: fix a bug about 'copy from selenoid and paste to selenoid' #497

merged 7 commits into from
Oct 13, 2022

Conversation

kaylezhangzhaoLin
Copy link
Contributor

description: Send the request to another container can not use ip=localhost, should use linked container name + port

    1. copy from selenoid clipboard to local
    2. paste to selenoid from local clipboard
    1. copy from selenoid clipboard to local
    2. paste to selenoid from local clipboard
    1. copy from selenoid clipboard to local
    2. paste to selenoid from local clipboard
    1. copy from selenoid clipboard to local
    2. paste to selenoid from local clipboard
    1. copy from selenoid clipboard to local
    2. paste to selenoid from local clipboard
    description: Send the request to another container can not use ip=localhost, should use linked container name + port
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 31.42% // Head: 30.71% // Decreases project coverage by -0.70% ⚠️

Coverage data is based on head (f644922) compared to base (8168510).
Patch coverage: 4.16% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
- Coverage   31.42%   30.71%   -0.71%     
==========================================
  Files          38       38              
  Lines         732      752      +20     
  Branches      131      137       +6     
==========================================
+ Hits          230      231       +1     
- Misses        441      458      +17     
- Partials       61       63       +2     
Flag Coverage Δ
go 30.71% <4.16%> (-0.71%) ⬇️
ui 22.59% <4.16%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ui/src/components/VncCard/index.js 0.00% <0.00%> (ø)
ui/src/setupProxy.js 0.00% <0.00%> (ø)
ui/src/components/VncCard/style.css.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lanwen lanwen merged commit bd7acd1 into aerokube:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants