-
Notifications
You must be signed in to change notification settings - Fork 215
[ENH] Added BaseDeepForecaster in forecasting/deep_learning #2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i like to get it in so we can use it in TCN and Informer PRs. @MatthewMiddlehurst @TonyBagnall any comments on it ?
self.last_window_ = y_inner[-self.window :] | ||
return self | ||
|
||
def _predict(self, y=None, X=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer exog to X. This appeared in the wrong place
def _predict(self, y, exog=None)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didnt notice that good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments other than those Tony has posted for now. Try to match the syntax and terminology used in the module. Consider of things such as the new mixins as well, they may not be required here specifically but is there anything special for deep learners that we need to think about.
i would keep mixins for models themselves, as not all deep learners follow the same setup |
Reference Issues/PRs
Fixes #2904.
What does this implement/fix? Explain your changes.
To lay the groundwork for future deep learning forecasters in aeon, BaseDeepForecaster class has been developed. This class abstracts common deep learning workflows for forecasting, such as input conversion, sequence generation, model compilation, training, and prediction.
Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
This modular base class will serve as the foundation for integrating advanced deep learning models like Informer, TCN, and DeepAR into the aeon toolkit.
PR checklist
For all contributions
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access