[ENH] enhance naive forecaster with new strategies #2869
Conversation
aeon-actions-bot
bot
added
enhancement
Thank you for contributing to
|
aeon/forecasting/_naive.py
Outdated
| Parameters | ||
| ---------- | ||
| strategy : str, default="last" | ||
| The forecasting strategy to use. | ||
| Options: "last", "mean", "seasonal_last". | ||
| seasonal_period : int, default=1 | ||
| The seasonal period to use for the "seasonal_last" strategy. | ||
| E.g., 12 for monthly data with annual seasonality. | ||
| horizon : int, default=1 | ||
| The number of time steps ahead to forecast. |
There was a problem hiding this comment.
This should be in the class docstring.
aeon/forecasting/_naive.py
Outdated
| Strategies: | ||
| - "last": predicts the last seen value in training for all horizon steps. | ||
|
|
||
| - "mean": predicts the mean of the training series for all horizon steps. | ||
|
|
||
| - "seasonal_last": predict the last season value seen in the training series. | ||
| Returns np.nan if the effective seasonal data is empty. |
There was a problem hiding this comment.
Include this in the Parameter documentation instead
aeon/forecasting/_naive.py
Outdated
| self._fitted_scalar_value_ = None # For 'last' and 'mean' strategies | ||
| self._fitted_last_season_ = np.array([]) # For 'seasonal_last', init as empty |
There was a problem hiding this comment.
do this in _fit ideally
aeon/forecasting/tests/test_naive.py
Outdated
| def sample_data(): | ||
| """Pytest fixture for sample time series data.""" | ||
| return np.array([10, 20, 30, 40, 50]) |
There was a problem hiding this comment.
Don't think this is needed, can just create the array in each test.
Reference Issues/PRs
Fixes #2823.
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
PR checklist
For all contributions
For new estimators and functions
__maintainer__at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access