-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Adding type hinting for files: aeon/benchmarking/* #2667
base: main
Are you sure you want to change the base?
[ENH] Adding type hinting for files: aeon/benchmarking/* #2667
Conversation
Thank you for contributing to
|
f005d02
to
1e26a5e
Compare
52ee90d
to
a0ab705
Compare
@baraline @MatthewMiddlehurst @hadifawaz1999 @TonyBagnall Could you please review this PR? I have addressed all the necessary changes. Thanks! |
Reference Issues/PRs
Fixes #1454 some part
What does this implement/fix? Explain your changes.
I have added type hinting in the files. For this I also needed to import from typing such as List, Union etc.
I have added hints just in the parameter of some functions in the python files.
Does your contribution introduce a new dependency? If yes, which one?
No
Any other comments?
I will work on some other folders if this PR gets done. I am new to Open Source. This is my first contribution and I loved it. Thanks.
PR checklist
For all contributions