Skip to content

[DOC] Documentation improvement of BaseDeepClassifier and BaseCollectionEstimator #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion aeon/base/_base_collection.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,24 @@
"""Base class for estimators that fit collections of time series."""
"""
Base class for estimators that fit collections of time series.

class name: BaseCollectionEstimator

Defining methods:
preprocessing - _preprocess_collection(self, X, store_metadata=True)
input checking - _check_X(self, X)
input conversion - _convert_X(self, X)
shape checking - _check_shape(self, X)

Inherited inspection methods:
hyper-parameter inspection - get_params()
fitted parameter inspection - get_fitted_params()

State:
fitted model/strategy - by convention, any attributes ending in "_"
fitted state flag - is_fitted (property)
fitted state inspection - check_is_fitted()

"""

from abc import abstractmethod

Expand Down
17 changes: 17 additions & 0 deletions aeon/classification/deep_learning/base.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,23 @@
"""
Abstract base class for the Keras neural network classifiers.

class name: BaseDeepClassifier

Defining methods:
fitting - fit(self, X, y)
predicting - predict(self, X)
- predict_proba(self, X)
model building - build_model(self, input_shape, n_classes) (abstract method)

Inherited inspection methods:
hyper-parameter inspection - get_params()
fitted parameter inspection - get_fitted_params()

State:
fitted model/strategy - by convention, any attributes ending in "_"
fitted state flag - is_fitted (property)
fitted state inspection - check_is_fitted()

The reason for this class between BaseClassifier and deep_learning classifiers is
because we can generalise tags, _predict and _predict_proba
"""
Expand Down