Skip to content

[ENH] Update remaining registry files #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 16, 2024
Merged

[ENH] Update remaining registry files #2198

merged 10 commits into from
Oct 16, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

  • remove current contents of registry
  • base class lists and utilities have been moved to utils.base and reworked into a dictionary.
  • all_estimators has been simplified a bit and moved to utils.discovery (same import as sklearn)
  • adds check_tag_value to help validating the value of singular tags

@MatthewMiddlehurst MatthewMiddlehurst added the enhancement New feature, improvement request or other non-bug code enhancement label Oct 14, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aeon-actions-bot aeon-actions-bot bot added examples Example notebook related testing Testing related issue or pull request labels Oct 14, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the changes made: [ $\color{#45FD64}{\textsf{examples}}$, $\color{#2C2F20}{\textsf{testing}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks fine, but we could do with going over all base classes, make sure they have abstract constructors etc and resolve #2177

@TonyBagnall TonyBagnall merged commit fb877e7 into main Oct 16, 2024
15 checks passed
@TonyBagnall TonyBagnall deleted the mm/registry branch October 16, 2024 13:24
notaryanramani pushed a commit to notaryanramani/aeon that referenced this pull request Oct 16, 2024
* registry refactor

* all_estimators

* comments and qc

* fixes

* fixes

* exclude sklearn in docs

* examples

* examples
TonyBagnall added a commit that referenced this pull request Oct 24, 2024
* Implemented COPOD for anomaly detection

* fix: type annotations for python3.9

* fix: changed method decorator

* test: soft dependencies check

* [DOC] Add JMLR paper to readme (#2203)

* add paper

* add paper

* [DOC, ENH] Add WEASEL v2 and Human Activity Challenge Papers (#2204)

* add WEASEL v2 paper

* add ECML challenge

* [ENH] Update remaining `registry` files (#2198)

* registry refactor

* all_estimators

* comments and qc

* fixes

* fixes

* exclude sklearn in docs

* examples

* examples

* [MNT] Changes in preparation for update to `numpy` 2 (#1813)

* numpy 2

* Update pyproject.toml

* bound

* scipy bound

* correct method

* not 2.1.0

* comment deps

* comment deps

* comment deps

* make numpy 2.0 compatible

* restore current numpy bound

* revert to main pyproject

* Empty commit for CI

---------

Co-authored-by: aadya940 <aadya@unify.ai>
Co-authored-by: Tony Bagnall <a.j.bagnall@soton.ac.uk>
Co-authored-by: Tony Bagnall <ajb@uea.ac.uk>
Co-authored-by: TonyBagnall <TonyBagnall@users.noreply.github.com>

* [ENH] Split up rocket estimators (#2207)

* split up rocket

* test params

* test params

* test params

* more fixes for float_ (#2215)

* Implemented COPOD for anomaly detection

* update: added new test cases

* changes: clean up

---------

Co-authored-by: Tony Bagnall <a.j.bagnall@soton.ac.uk>
Co-authored-by: Patrick Schäfer <patrick.schaefer@hu-berlin.de>
Co-authored-by: Matthew Middlehurst <pfm15hbu@gmail.com>
Co-authored-by: aadya940 <aadya@unify.ai>
Co-authored-by: Tony Bagnall <ajb@uea.ac.uk>
Co-authored-by: TonyBagnall <TonyBagnall@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement examples Example notebook related testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants