-
Notifications
You must be signed in to change notification settings - Fork 218
[ENH] add BaseSeriesTransformer - ExpSmoothingSeriesTransformer #2019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for contributing to
|
625fa76
to
275fee4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good spot on the typo, but I would prefer this to be axis = 1 as it is our standard
59588fd
to
0ed378d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the changes
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
Any other comments?
Paper: s_0 = t_0 and s_j = alpha * t_j + (1 - alpha) * t_j-1
Corrected: s_0 = t_0 and s_j = alpha * t_j + (1 - alpha) * s_j-1
PR checklist
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.For developers with write access