-
Notifications
You must be signed in to change notification settings - Fork 218
[ENH] Discrete Fourier Approximation Transformer #1967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for contributing to
|
Here is a visualization of
|
@TonyBagnall I would like to mention you and ask for your opinion as you are the "feature requester". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
@all-contributors add @Cyril-Meyer for code. |
I've put up a pull request to add @Cyril-Meyer! 🎉 |
Reference Issues/PRs
Implement DFT asked in #1920.
What does this implement/fix? Explain your changes.
Add a new transformation, named
DFTSeriesTransformer
.The simplified algorithm is the following :
Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
Removed terms can be sorted by amplitude before removal to keep most important terms instead of first ones.
I based my code using
BKFilter
class as a template.PR checklist
For all contributions
-> I will use the bot when the PR is considered as ok.
For new estimators and functions
__maintainer__
at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.