Skip to content

Conversation

Cyril-Meyer
Copy link
Contributor

Reference Issues/PRs

Implement DFT asked in #1920.

What does this implement/fix? Explain your changes.

Add a new transformation, named DFTSeriesTransformer.
The simplified algorithm is the following :

  1. Compute FFT
  2. Remove a proportion of terms (r paramter)
  3. Compute invert FFT

Does your contribution introduce a new dependency? If yes, which one?

No.

Any other comments?

Removed terms can be sorted by amplitude before removal to keep most important terms instead of first ones.

I based my code using BKFilter class as a template.

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
    -> I will use the bot when the PR is considered as ok.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.

@Cyril-Meyer Cyril-Meyer requested a review from aiwalter as a code owner August 13, 2024 17:08
@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package labels Aug 13, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@Cyril-Meyer
Copy link
Contributor Author

Here is a visualization of x12r vs fit_transform(x12r) with the tests parameters.
This looks good to me, but I may have misunderstood what is requested in #1920.

r Unsorted Sorted
0.00 0 0_False 0 0_True
0.25 0 25_False 0 25_True
0.50 0 5_False 0 5_True
0.75 0 75_False 0 75_True
1.00 1 0_False 1 0_True

@Cyril-Meyer
Copy link
Contributor Author

@TonyBagnall I would like to mention you and ask for your opinion as you are the "feature requester".

Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@Cyril-Meyer
Copy link
Contributor Author

@all-contributors add @Cyril-Meyer for code.

Copy link
Contributor

@Cyril-Meyer

I've put up a pull request to add @Cyril-Meyer! 🎉

@hadifawaz1999 hadifawaz1999 merged commit 766360f into aeon-toolkit:main Aug 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants