Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] K-Means anomaly detector #1607

Merged
merged 13 commits into from
Jun 11, 2024
Merged

[ENH] K-Means anomaly detector #1607

merged 13 commits into from
Jun 11, 2024

Conversation

SebastianSchmidl
Copy link
Member

@SebastianSchmidl SebastianSchmidl commented Jun 5, 2024

Reference Issues/PRs

Depends on #1605

What does this implement/fix? Explain your changes.

Introduces a new anomaly detection algorithm: KMeansAD with tests and docs.

Does your contribution introduce a new dependency? If yes, which one?

no

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@SebastianSchmidl SebastianSchmidl added enhancement New feature, improvement request or other non-bug code enhancement implementing algorithms Implementing new algorithms/estimators anomaly detection Anomaly detection package labels Jun 5, 2024
@SebastianSchmidl SebastianSchmidl self-assigned this Jun 5, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#6F6E8D}{\textsf{anomaly detection}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

TonyBagnall
TonyBagnall previously approved these changes Jun 5, 2024
Copy link
Contributor

@TonyBagnall TonyBagnall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice documentation

@MatthewMiddlehurst
Copy link
Member

Left some comments on the related PR, should merge that first.

@MatthewMiddlehurst MatthewMiddlehurst merged commit a216bb0 into main Jun 11, 2024
13 of 14 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the feat/kmeans branch June 11, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly detection Anomaly detection package enhancement New feature, improvement request or other non-bug code enhancement implementing algorithms Implementing new algorithms/estimators ready for review This PR is ready for reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants