Skip to content

[BUG] Dependencies version checking not handling python release candidate correctly #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2024
Merged

[BUG] Dependencies version checking not handling python release candidate correctly #1450

merged 1 commit into from
Apr 27, 2024

Conversation

baraline
Copy link
Member

Reference Issues/PRs

Fixes #1395

What does this implement/fix? Explain your changes.

Allow release candidate version in python version checking.

@baraline baraline linked an issue Apr 22, 2024 that may be closed by this pull request
[BUG] Dependencies version checking not handling python release candidate correctly #1395
Closed
@aeon-actions-bot aeon-actions-bot bot added the bug Something isn't working label Apr 22, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#d73a4a}{\textsf{bug}}$ ].

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

@baraline baraline added full pytest actions Run the full pytest suite on a PR full pre-commit Run pre-commit for all files on a PR full examples run Run all examples on a PR and removed full pre-commit Run pre-commit for all files on a PR labels Apr 22, 2024
@baraline baraline merged commit f82940c into main Apr 27, 2024
@baraline baraline deleted the 1395-bug-dependencies-version-checking-not-handling-python-release-candidate-correctly branch April 27, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewMiddlehurst MatthewMiddlehurst MatthewMiddlehurst approved these changes

@chrisholder chrisholder Awaiting requested review from chrisholder

Assignees
No one assigned
Labels
bug Something isn't working full examples run Run all examples on a PR full pytest actions Run the full pytest suite on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Dependencies version checking not handling python release candidate correctly
2 participants
@baraline @MatthewMiddlehurst