Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/customize probe settings in pod spec #97

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Feature/customize probe settings in pod spec #97

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
dc7c7b1
Add default probe tests
ilya-hontarau Mar 29, 2024
9af5e40
Add configure probes functions
ilya-hontarau Mar 29, 2024
1262e38
Regenerate spec files
ilya-hontarau Mar 29, 2024
4c674d2
Add probe tests for CreateOrUpdateStatefulSet
ilya-hontarau Mar 29, 2024
9e4a171
Fix using ginkgo by func
ilya-hontarau Mar 29, 2024
73d7ccc
Use probe handler from config
ilya-hontarau Mar 29, 2024
2952d91
Add comments about default probes
ilya-hontarau Mar 29, 2024
71539c2
Make merge default probe pure
ilya-hontarau Mar 29, 2024
133e1b4
Remove unneeded deep copy
ilya-hontarau Mar 29, 2024
27daf04
Set initial delay seconds for startup probe as 0
ilya-hontarau Apr 2, 2024
acd264a
Add probes comments with default values
ilya-hontarau Apr 2, 2024
f5b2f67
Remove initial delay seconds for probes
ilya-hontarau Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add probes comments with default values
  • Loading branch information
@ilya-hontarau
ilya-hontarau committed Apr 2, 2024
commit acd264a55cc4589e84d99122e274501e0265ddd5
9 changes: 6 additions & 3 deletions api/v1alpha1/etcdcluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,17 +166,20 @@ type PodSpec struct {
ExtraEnv []corev1.EnvVar `json:"extraEnv,omitempty"`

// LivenessProbe defines liveness probe check for the pod.
sircthulhu marked this conversation as resolved.
Show resolved Hide resolved
// If not specified, default probe will be used.
// If not specified, default probe will be used with HTTP probe handler and path /livez on the port 2379,
// with initialDelaySeconds 5 and periodSeconds 5.
// +optional
LivenessProbe *corev1.Probe `json:"livenessProbe,omitempty"`

// ReadinessProbe defines readiness probe check for the pod.
// If not specified, default probe will be used.
// If not specified, default probe will be used with HTTP probe handler and path /readyz on the port 2379,
// with initialDelaySeconds 5 and periodSeconds 5.
// +optional
ReadinessProbe *corev1.Probe `json:"readinessProbe,omitempty"`

// StartupProbe defines startup probe check for the pod.
// If not specified, default probe will be used.
// If not specified, default probe will be used with HTTP probe handler and path /readyz?serializable=false on the port 2379,
// with periodSeconds 5.
// +optional
StartupProbe *corev1.Probe `json:"startupProbe,omitempty"`
}
Expand Down