Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate tags and version automatically #100

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Calculate tags and version automatically #100

merged 1 commit into from
Apr 24, 2024

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Apr 23, 2024

This PR improves development experence:

  1. Remove prepare_release.sh script

  2. Calucalte TAG automatically from git describe --tags --exact-match and replaced to latest for in case if tag is not assigned.

  3. Allow overriding REGISTRY=<docker_tag> and TAG=<git_tag> via makefile, eg:

    make REGISTRY=ghcr.io/kvaps/cozystack TAG=latest
    
  4. Enable in-line cache, which is now downloaded from :latest images

  5. Calculate version and set automatically for the Helm charts from git describe --tags --abbrev=0

@kvaps kvaps changed the title Dynamic tags Calculate tags and version automatically Apr 23, 2024
@kvaps kvaps force-pushed the dynamic-tags branch 2 times, most recently from 1c2baf9 to dff30f7 Compare April 23, 2024 17:03
@kvaps kvaps marked this pull request as ready for review April 23, 2024 17:04
@kvaps kvaps force-pushed the dynamic-tags branch 3 times, most recently from e6a7a01 to e971fc3 Compare April 23, 2024 17:08
@kvaps kvaps requested review from themoriarti and gecube April 23, 2024 17:10
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Copy link
Collaborator

@themoriarti themoriarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually, everything is normal, but I did not check locally, if no one is against it, then we can merge.

@kvaps kvaps merged commit 20fcd25 into main Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants