Skip to content

Conversation

@msooseth
Copy link
Contributor

@msooseth msooseth commented Apr 5, 2022

This may help. I'll hack it a bit more.

@msoos
Copy link
Contributor

msoos commented Apr 5, 2022

This seems to give a lot of speedup. But maybe there is a bug...

@msoos
Copy link
Contributor

msoos commented Apr 5, 2022

Yep, there is a bug :)

@aehyvari
Copy link
Owner

aehyvari commented Apr 5, 2022

Sure! I'll wait for the previous results (cluster's busy...) and then give this one a go!

@msoos
Copy link
Contributor

msoos commented Apr 5, 2022

I think this may be OK now, so when you have time and the cluster is not too busy, it'd be nice to see the performance :)

Copy link
Owner

@aehyvari aehyvari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After running all the benchmarks, this starts to look really good. However, I left one question that puzzled me. I have a version that I'm cleaning for opensmt master, we can continue the discussion there once I manage to make the PR.

@msooseth
Copy link
Contributor Author

I'm super-happy to see that this has improved performance! By the way, with in-line distillation, I am pretty sure we could make the solver about 1.5x faster. Maybe I'll have a go at it sometime later today, see if you like it :) It basically tries to simplify the learnt clauses once in a while. It's super effective. I have been hacking my SAT solver to bits lately and it's helped a lot with the performance of my counting tool... I'm back in the game again :)

@aehyvari
Copy link
Owner

I'm super-happy to see that this has improved performance! By the way, with in-line distillation, I am pretty sure we could make the solver about 1.5x faster. Maybe I'll have a go at it sometime later today, see if you like it :) It basically tries to simplify the learnt clauses once in a while. It's super effective. I have been hacking my SAT solver to bits lately and it's helped a lot with the performance of my counting tool... I'm back in the game again :)

We should absolutely try it out, sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants