CSIRO Extra test rules and code changes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d required modifications to create descriptiontype refset table
Also introduce new test category and allow for SQL test re-load
…c/release-validation-framework into feature/csiro-extra-rules-1
…ules-2 * feature/csiro-extra-rules-1: this skew test requires same sourcetime equality as well Add tests checking for extraneous SNAPSHOT entries Missed another field in test Fix test Include tests in manifest Check for version skew in dependency targets MDRS rows should all be in the MDRS refset initial MDRS validation tests (derived from Ontoserver)
… new test to check edition modiule dependencies in MDRS
…rules-20210421 * feature/csiro-extra-rules-1: this skew test requires same sourcetime equality as well Add tests checking for extraneous SNAPSHOT entries Missed another field in test Fix test Include tests in manifest Check for version skew in dependency targets MDRS rows should all be in the MDRS refset initial MDRS validation tests (derived from Ontoserver)
…nto feature/csiro-exctra-rules-20210421 * file-centric-snapshot-language-unknown-acceptability: Add curr_ to table name Only need to check for active lang refset entries Add file-centric-snapshot-language-unknown-acceptability test
…into feature/csiro-exctra-rules-20210421 * file-centric-snapshot-mdrs-referenced-module-inactive: Add curr_ to tablenames Only check active MDRS rows Referenced module in the MRDS is inactive
…rules-20210421 * feature/csiro-extra-rules-2: Added expected Belgian extension filename map Add file name mappint to edition for NL, AU, NZ, US, INT Fix module and version parsing, get them from release file names. Add new test to check edition modiule dependencies in MDRS Change root concept assertion's severity to warning Root concept (concept that has no isa) shouldn't really have non-isa relationships Add test for root concepts that have non-isa relationships Add curr_ to table names And only look at active description types Only look at active descriptions Add file-centric-snapshot-description-invalid-descriptiontype test and required modifications to create descriptiontype refset table
jimsteel
reviewed
Apr 22, 2021
| return editionAndVersion; | ||
| } | ||
|
|
||
| private String mapFilnameToEdition(String name) { |
jimsteel
reviewed
Apr 22, 2021
| @Autowired | ||
| private AssertionService assertionService; | ||
|
|
There was a problem hiding this comment.
Fixing their whitespace is probably outside our remit
There was a problem hiding this comment.
That's probably just an artefact of an editor configuration
edeati
commented
Apr 23, 2021
lawley
reviewed
Apr 23, 2021
docker-compose.yml
Outdated
| depends_on: | ||
| - db | ||
| environment: | ||
| - rvf.assertion.import.required=true |
There was a problem hiding this comment.
This is new config, which is really handy when authoring / updating the SQL rules, but it may not be what they want as a default?
There was a problem hiding this comment.
Removed new config from docker-compose so it won't be part of the pull request
Comment on lines
90
to
95
| // DK("DK", "DanishEdition"), | ||
| // SE("SE", "SwedishEdition"), | ||
| // NO("NO", "NorwegianEdition"), | ||
| // CH("CH", "SwissEdition"), | ||
| // IE("IE", "IrishEdition"), | ||
| // EE("EE", "EstonianEdition"), |
There was a problem hiding this comment.
Danish edition | 554471000005108
Swedish edition | 45991000052106
Norwegian edition | 51000202101
Irish edition | 11000220105
Estonian edition | 11000181102
There was a problem hiding this comment.
Just pushed a change to add these modules
jimsteel
approved these changes
Apr 23, 2021
…uld only have one version referenced in the snapshot
…com/aehrc/release-validation-framework into feature/csiro-exctra-rules-20210421
…ll transitive dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Csiro extra test rules