Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: loading/error states for markdown images #1733

Merged
merged 6 commits into from
Nov 18, 2024
Merged

feat: loading/error states for markdown images #1733

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8902ede
feat: loading/error states for markdown images
aeharding Nov 17, 2024
ddbd2e4
refactor
aeharding Nov 17, 2024
c72c237
cleanup
aeharding Nov 18, 2024
fe14573
cleanup
aeharding Nov 18, 2024
5ad70d1
cleanup
aeharding Nov 18, 2024
9fc9f9c
More cleanup
aeharding Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
@aeharding
aeharding committed Nov 18, 2024
commit fe1457378c2bc81701c5449999bff85db6f00ba3
2 changes: 1 addition & 1 deletion src/features/shared/markdown/MarkdownImg.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const mediaStyles = css`

&.not-loaded {
height: 200px;
border: 1px solid rgba(100, 100, 100, 0.2);
border: 1px solid rgba(var(--ion-color-dark-rgb), 0.15);
}
`;

Expand Down