Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace linaria with css modules #1658

Merged
merged 22 commits into from
Nov 23, 2024
Merged

refactor: replace linaria with css modules #1658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
50a6cee
Add CSS modules experiment
aeharding Nov 5, 2024
9e23c09
fix
aeharding Nov 15, 2024
876d9c2
more experiment
aeharding Nov 15, 2024
d6283a0
Setup overrides, testing more components
aeharding Nov 19, 2024
05f5998
Update vscode extensions
aeharding Nov 19, 2024
ba0a0ae
cleanup
aeharding Nov 20, 2024
c27c32c
More modules
aeharding Nov 21, 2024
2bd46f8
Moar modules
aeharding Nov 21, 2024
ad2fc4a
Add lightning, remove unused
aeharding Nov 21, 2024
0aecccd
Add more modules
aeharding Nov 22, 2024
23e3c6a
rename
aeharding Nov 22, 2024
8f5e3cc
Add build step
aeharding Nov 22, 2024
937972d
Move androidClose
aeharding Nov 22, 2024
5fc971c
Move filters
aeharding Nov 22, 2024
c101ad7
More
aeharding Nov 22, 2024
b5c42e9
Progress
aeharding Nov 23, 2024
6efd876
Finish migrate
aeharding Nov 23, 2024
f44b364
Set lightning as bundler
aeharding Nov 23, 2024
35170d6
type issues
aeharding Nov 23, 2024
bcf0f33
cleanup
aeharding Nov 23, 2024
64efaef
Add tsc step
aeharding Nov 23, 2024
8380795
Fix logic
aeharding Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,11 @@ jobs:
- name: 📝 Prettier formatting
run: pnpm lint:formatting

- name: 📝 Generate CSS types
run: pnpm test:generatecsstypes

- name: 💪 Type check
run: pnpm test:typecheck

- name: 📦 Build
run: pnpm build
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,5 @@ fly.toml
/playwright-report/
/blob-report/
/playwright/.cache/

*.css.d.ts
4 changes: 2 additions & 2 deletions .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"recommendations": [
"ionic.ionic",
"esbenp.prettier-vscode",
"styled-components.vscode-styled-components",
"github.vscode-github-actions"
"github.vscode-github-actions",
"clinyong.vscode-css-modules"
]
}
4 changes: 3 additions & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@
"editor.codeActionsOnSave": {
"source.fixAll.eslint": "explicit"
},
"eslint.codeActionsOnSave.rules": ["perfectionist/*"]
"eslint.codeActionsOnSave.rules": ["perfectionist/*"],
"css.lint.validProperties": ["composes"],
"css.lint.vendorPrefix": "ignore"
}
10 changes: 4 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"preview": "vite preview",
"test": "vitest",
"test:e2e": "playwright test",
"test:generatecsstypes": "tcm src",
"test:typecheck": "tsc",
"lint": "eslint src --max-warnings=0",
"lint:formatting": "prettier --check .",
Expand Down Expand Up @@ -65,8 +66,6 @@
"@ionic/core": "npm:voyager-ionic-core@8.4.0",
"@ionic/react": "8.4.0",
"@ionic/react-router": "8.4.0",
"@linaria/core": "^6.2.0",
"@linaria/react": "^6.2.1",
"@mantine/hooks": "^7.14.0",
"@reduxjs/toolkit": "^2.3.0",
"capacitor-android-nav-mode": "^1.0.0",
Expand Down Expand Up @@ -122,8 +121,6 @@
"virtua": "^0.37.0"
},
"devDependencies": {
"@babel/preset-react": "^7.25.9",
"@babel/preset-typescript": "^7.26.0",
"@capacitor/cli": "^6.1.2",
"@eslint/js": "^9.14.0",
"@ionic/cli": "^7.2.0",
Expand All @@ -139,7 +136,6 @@
"@types/ua-parser-js": "^0.7.39",
"@vitejs/plugin-legacy": "^5.4.3",
"@vitejs/plugin-react": "^4.3.3",
"@wyw-in-js/vite": "^0.5.5",
"babel-plugin-react-compiler": "0.0.0-experimental-19c7e06-20241113",
"eslint": "^9.14.0",
"eslint-config-prettier": "^9.1.0",
Expand All @@ -148,16 +144,18 @@
"eslint-plugin-react-hooks": "0.0.0-experimental-b01722d5-20241114",
"eslint-plugin-vitest": "^0.5.4",
"jsdom": "^25.0.1",
"lightningcss": "^1.28.1",
"mdast-util-lemmy-spoiler": "^2.0.0",
"prettier": "^3.3.3",
"pwa-asset-generator": "^6.4.0",
"release-it": "^17.10.0",
"typed-css-modules": "^0.9.1",
"typescript": "^5.6.3",
"typescript-eslint": "^8.14.0",
"vite": "^5.4.11",
"vite-css-modules": "^1.5.2",
"vite-plugin-pwa": "^0.21.0",
"vite-plugin-svgr": "^4.3.0",
"vite-tsconfig-paths": "^5.1.2",
"vitest": "^2.1.5"
}
}
Loading