Update Playwright config to choose the test web server based on env #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When `process.env.CI` is true (in a GitHub action, for instance), tests run on the production build; otherwise, they run on the dev server.
|
Thanks! |
|
Hey, I added you as a contributor to the project! I also added a CODEOWNERS. I added you as the owner for Of course I am happy (and excited) to check out your PRs too! Hopefully this just removes some friction. |
|
Thanks! Unlikely that I will merge anything without a review but appreciate the trust. Beats working with a fork any day 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
process.env.CI === true, Playwright will usepnpm preview, otherwisepnpm dev.