Setup Playwright for end-to-end testing #1392
Conversation
* Vite tries to run all test files by default. The directory containing Playwright tests (`e2e/`) and `node_modules/` need to be excluded in vite.config.ts.
* Tests currently depend on locally stored test data.
There was a problem hiding this comment.
Hi! Thanks so much, this is a pleasant surprise! The PR looks great, just a small thing to get the build passing.
I'd love to get this running in CI - could you add a Github Action to .github folder? Otherwise, I am happy to look into it.
Also we should probably document in README.md but if you want to add in a follow up PR I am fine with that too.
Co-authored-by: Alexander Harding <2166114+aeharding@users.noreply.github.com>
* Add e2e.yml to run Playwright tests in a container using an image provided by the Playwright team. * Update Playwright config to run tests against a production build of the app instead of the dev server. * Add script to package.json to run Playwright tests.
Appreciate the welcome. Looking forward to making meaningful contributions to the project.
Can't believe I missed that. Fixed.
Done.
Wondering if it might be better to wait until a somewhat acceptable test coverage has been achieved? Or did I completely misunderstand what you were suggesting? |
There was a problem hiding this comment.
Wondering if it might be better to wait until a somewhat acceptable test coverage has been achieved? Or did I completely misunderstand what you were suggesting?
Yes I'm totally fine with waiting until later. :) I mostly am asking because I wasn't sure how best to run e2e tests locally - but I found npx playwright test works well. Probably just because I haven't used playwright before!
I changed Playwright's config to run off On a somewhat related note, do you have any preference regarding the size of PRs? If you usually squash and merge, I am guessing smaller and more frequent PRs would make sense. |
The main reason I squash is to remove invalid/intermediate commits like "progress" or whatever that would add noise to main. Ideally every commit in main is a standalone bit of work. If you would prefer to merge without squashing for larger PRs I can totally do that, assuming the commits for the PR are cleaned up before merging ( |
|
That makes sense. I will try and keep PRs small and focused so we don't have to worry preserving commit history. |
I emailed a few months ago because I wanted to add e2e testing to the app. It has been a while (sorry) but here is my first PR.
What's been done?
What's next?
I intend to contribute regularly going forward. Depending on the number of testing scenarios and their complexity, I might split tests for a page/view into more than one PR.